Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): incident add a comment uses old API #2291

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix(ui): incident add a comment uses old API #2291

merged 1 commit into from
Oct 24, 2024

Conversation

shahargl
Copy link
Member

close #2290

@vercel Vercel
Copy link

vercel bot commented Oct 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 3:38pm

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 24, 2024
@shahargl shahargl requested a review from talboren October 24, 2024 15:35
@dosubot dosubot bot added the UI User interface related issues label Oct 24, 2024
@talboren talboren changed the title fix: add a comment fix: incident add a comment uses old API Oct 24, 2024
talboren
talboren approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 24, 2024
@talboren talboren changed the title fix: incident add a comment uses old API fix(ui): incident add a comment uses old API Oct 24, 2024
@shahargl shahargl merged commit 7290eb0 into main Oct 24, 2024
13 checks passed
@shahargl shahargl deleted the bugfix/add-comment branch October 24, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talboren talboren talboren approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. UI User interface related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: wrong usage of getapiurl
2 participants
@shahargl @talboren